Issue 179783004: Verify the default locale in case we're given an invalid one and need to fall back.

Issue 179783004: Verify the default locale in case we're given an invalid one and need to fall back. (Closed)

Created:
6 years, 10 months ago by Alan Knight

Modified:
6 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Verify the default locale in case we're given an invalid one and need to fall back. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=33032

Patch Set 2 : Review fixes #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -4 lines)			Patch
M	pkg/intl/example/basic/messages_all.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/intl/lib/generate_localized.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/intl/lib/intl.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/intl/test/intl_test.dart	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
M	pkg/intl/test/message_extraction/foo_messages_all.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

This comes up if you do Intl.default = 'en-XYZ'; .... we should fall back to ...

6 years, 10 months ago (2014-02-25 19:05:58 UTC) #1

Emily Fortuna

https://codereview.chromium.org/179783004/diff/1/pkg/intl/example/basic/messages_all.dart File pkg/intl/example/basic/messages_all.dart (right): https://codereview.chromium.org/179783004/diff/1/pkg/intl/example/basic/messages_all.dart#newcode36 pkg/intl/example/basic/messages_all.dart:36: onFailure: (_) => null); tabs alert! https://codereview.chromium.org/179783004/diff/1/pkg/intl/test/intl_test.dart File pkg/intl/test/intl_test.dart ...

6 years, 10 months ago (2014-02-25 19:16:36 UTC) #2

Alan Knight

Oops. That's what I get for editing in emacs. https://codereview.chromium.org/179783004/diff/1/pkg/intl/example/basic/messages_all.dart File pkg/intl/example/basic/messages_all.dart (right): https://codereview.chromium.org/179783004/diff/1/pkg/intl/example/basic/messages_all.dart#newcode36 pkg/intl/example/basic/messages_all.dart:36: ...

6 years, 10 months ago (2014-02-25 19:18:55 UTC) #3

Alan Knight

6 years, 10 months ago (2014-02-25 19:26:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r33032 (presubmit successful).

Expand Messages | Collapse Messages