Issue 179763004: Skipping Angular tests timing out on Dartium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179763004: Skipping Angular tests timing out on Dartium (Closed)

Created:
6 years, 10 months ago by blois

Modified:
6 years, 10 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Skipping Angular tests timing out on Dartium The dirty checking test is a new one, but the ng_repeat test is existing (though something obviously changed on it). Skipping while investigating what the issue is. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=33085

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r33085 (presubmit successful).

6 years, 10 months ago (2014-02-26 20:55:31 UTC) #1

vsm

6 years, 10 months ago (2014-02-26 20:58:43 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/179763004/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/179763004/diff/1/pkg/pkg.status#newcode286
pkg/pkg.status:286: third_party/angular_tests/browser_test/directive/ng_repeat:
Skip # Issue 17152
If these are passing in checked mode, you can put the Skip under:

[ .... && $unchecked ]

Expand Messages | Collapse Messages