Issue 179763002: Allow docgen --serve server to be accessed from IP addresses other than the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179763002: Allow docgen --serve server to be accessed from IP addresses other than the (Closed)

Created:
6 years, 10 months ago by dgrove

Modified:
6 years, 10 months ago

Reviewers:
Alan Knight, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allow docgen --serve server to be accessed from IP addresses other than the loopback. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=33020

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/docgen/lib/docgen.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

Does ANY_IP_V6 mean it only works if using IPv6? Otherwise LGTM

6 years, 10 months ago (2014-02-25 16:20:40 UTC) #2

dgrove

On 2014/02/25 16:20:40, Alan Knight wrote: > Does ANY_IP_V6 mean it only works if using ...

6 years, 10 months ago (2014-02-25 16:22:20 UTC) #3

dgrove

Committed patchset #1 manually as r33020 (presubmit successful).

6 years, 10 months ago (2014-02-25 16:36:08 UTC) #4

Emily Fortuna

6 years, 10 months ago (2014-02-25 18:24:50 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/179763002/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/179763002/diff/1/pkg/docgen/lib/docgen.dart#n...
pkg/docgen/lib/docgen.dart:770: 'http://localhost:${httpServer.port}');
Update the printed address here?

Expand Messages | Collapse Messages