Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1797113002: Add include_tags and exclude_tags config fields. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -87 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -1 line 0 comments Download
M doc/package_config.md View 4 chunks +41 lines, -6 lines 0 comments Download
M lib/src/runner/configuration/load.dart View 4 chunks +12 lines, -1 line 0 comments Download
M test/runner/configuration/tags_test.dart View 1 2 chunks +185 lines, -78 lines 0 comments Download
M test/runner/configuration/top_level_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
nweiz
4 years, 9 months ago (2016-03-14 23:47:03 UTC) #1
kevmoo
Test crashes 00:18 +94 -2: test/runner/configuration/tags_test.dart: errors exclude_tags rejects an invalid selector The schedule had ...
4 years, 9 months ago (2016-03-15 17:12:49 UTC) #2
kevmoo
https://codereview.chromium.org/1797113002/diff/1/lib/src/runner.dart File lib/src/runner.dart (right): https://codereview.chromium.org/1797113002/diff/1/lib/src/runner.dart#newcode133 lib/src/runner.dart:133: : '"$pattern"')); rebase silly?
4 years, 9 months ago (2016-03-15 17:14:25 UTC) #3
nweiz
Code review changes
4 years, 9 months ago (2016-03-17 18:49:57 UTC) #4
nweiz
> Test crashes DOne
4 years, 9 months ago (2016-03-17 18:50:09 UTC) #5
kevmoo
lgtm
4 years, 9 months ago (2016-03-17 19:08:24 UTC) #6
nweiz
4 years, 9 months ago (2016-03-17 20:06:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
11f47b6973df6db843a62f2bfca5857cf37f594c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698