Issue 179443004: VM: Replace StoreVMField with StoreInstanceField.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179443004: VM: Replace StoreVMField with StoreInstanceField. (Closed)

Created:
6 years, 10 months ago by Florian Schneider

Modified:
6 years, 10 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Replace StoreVMField with StoreInstanceField. This simplifies a lot of code in the optimizer and avoids the confusion and errors due to mismatch input operands when using StoreVMField. I added a separate constructor for LoadFieldInstr to avoid having to explicily set the associated field there. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=33059

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -306 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1 2	2 chunks	+1 line, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2	11 chunks	+24 lines, -45 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 2	1 chunk	+8 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	10 chunks	+25 lines, -48 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2	2 chunks	+7 lines, -10 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	7 chunks	+31 lines, -43 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2	8 chunks	+11 lines, -36 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	8 chunks	+11 lines, -36 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	6 chunks	+9 lines, -34 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	8 chunks	+11 lines, -36 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

6 years, 10 months ago (2014-02-26 12:12:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r33059 (presubmit successful).

Expand Messages | Collapse Messages