Issue 17943002: moved everything inside of the Docgen class into top level variables and functions. Also made most …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17943002: moved everything inside of the Docgen class into top level variables and functions. Also made most … (Closed)

Created:
7 years, 6 months ago by janicejl

Modified:
7 years, 5 months ago

Reviewers:
Tate Mandel, Emily Fortuna, Andrei Mouravski

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

moved everything inside of the Docgen class into top level variables and functions. Also made most of the helper functions private. This should aid unit testing as it would be possible to create a mirror system separately, and also generate one library object separately without everything being chained together by the docgen class. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=24550

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+274 lines, -290 lines)			Patch
	M	pkg/docgen/bin/docgen.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	pkg/docgen/lib/docgen.dart	View		4 chunks	+272 lines, -288 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

janicejl

7 years, 5 months ago (2013-06-27 21:12:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24550 (presubmit successful).

Expand Messages | Collapse Messages