Issue 179423003: Remove rum_vm_tests.host target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179423003: Remove rum_vm_tests.host target. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen

Modified:
6 years, 9 months ago

Reviewers:
ricow1, zra, Søren Gjesse, Bill Hesse, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove rum_vm_tests.host target. It should not be needed to compile it. If one wants to test the host, one should compile with toolchains; 'target' == 'host'. BUG= R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=33150

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -53 lines)			Patch
	M	runtime/bin/bin.gypi	View		1 chunk	+0 lines, -51 lines	0 comments	Download
	M	tools/bots/cross-vm.py	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Anders Johnsen

I think this is the right thing to do, but please enlighten me if I've ...

6 years, 10 months ago (2014-02-25 10:24:39 UTC) #1

Bill Hesse

I don't see any problems, but the other reviewers should approve it.

6 years, 10 months ago (2014-02-25 10:33:21 UTC) #2

zra

lgtm After discussion with Ivan, since test.dart is running on MIPS hardware, we are unlikely ...

6 years, 9 months ago (2014-02-28 00:11:49 UTC) #3

Anders Johnsen

6 years, 9 months ago (2014-02-28 08:55:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r33150 (presubmit successful).