Issue 17940002: Fix typo that caused orphaned info to be emitted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17940002: Fix typo that caused orphaned info to be emitted. (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 5 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, kasperl, Johnni Winther, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix typo that caused orphaned info to be emitted. BUG=http://dartbug.com/11533 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=24509

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

ahe

Not sure how to test this without rewriting FormattingDiagnosticHandler.diagnosticHandler which I don't think is the ...

7 years, 6 months ago (2013-06-26 21:11:35 UTC) #1

ahe

7 years, 5 months ago (2013-06-27 08:12:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24509 (presubmit successful).