Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 179163007: [polymer] skip linter in tests (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[polymer] skip linter in tests Arguably we should only be linting things reachable from deployment in deploy mode, but that's a bigger change. Combined with the previous CL for inline scripts (https://codereview.chromium.org/180933002/) this is enough to import polymer's many HTML elements without causing tests to timeout/fail/run out of memory due to unnecessary scanning ~300 HTML files. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=33146

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M pkg/polymer/lib/deploy.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/build/common.dart View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M pkg/polymer/lib/transformer.dart View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
6 years, 10 months ago (2014-02-26 19:06:33 UTC) #1
Siggi Cherem (dart-lang)
lgtm, consider adding a small TODO to write down what we discussed (that we probably ...
6 years, 10 months ago (2014-02-26 22:39:38 UTC) #2
Jennifer Messerly
thanks! https://codereview.chromium.org/179163007/diff/20001/pkg/polymer/lib/src/build/common.dart File pkg/polymer/lib/src/build/common.dart (right): https://codereview.chromium.org/179163007/diff/20001/pkg/polymer/lib/src/build/common.dart#newcode67 pkg/polymer/lib/src/build/common.dart:67: /// True to run liner on all html ...
6 years, 9 months ago (2014-02-28 03:00:22 UTC) #3
Jennifer Messerly
6 years, 9 months ago (2014-02-28 03:04:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r33146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698