Issue 179123010: Add timing info for file IO into Dart based analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179123010: Add timing info for file IO into Dart based analyzer. (Closed)

Created:
6 years, 9 months ago by scheglov

Modified:
6 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add timing info for file IO into Dart based analyzer. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33191

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -10 lines)			Patch
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	pkg/analyzer/bin/analyzer.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source_io.dart	View	2 chunks	+16 lines, -3 lines	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

Other than the version number, LGTM https://codereview.chromium.org/179123010/diff/1/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/179123010/diff/1/pkg/analyzer/pubspec.yaml#newcode2 pkg/analyzer/pubspec.yaml:2: version: 0.13.1-dev I ...

6 years, 9 months ago (2014-03-01 17:05:12 UTC) #2

scheglov

Committed patchset #1 manually as r33191 (presubmit successful).

6 years, 9 months ago (2014-03-01 19:47:42 UTC) #3

scheglov

6 years, 9 months ago (2014-03-02 06:01:08 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/179123010/diff/1/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/179123010/diff/1/pkg/analyzer/pubspec.yaml#ne...
pkg/analyzer/pubspec.yaml:2: version: 0.13.1-dev
On 2014/03/01 17:05:12, Brian Wilkerson wrote:
> I thought the version scheme was that once we had added "-dev" that future
> versions added numbers after. In other words, I think this is suppose to be
> "0.13.0-dev.1".

Done.

Expand Messages | Collapse Messages