Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 179093002: Only find package directory for things underneath lib (Closed)

Created:
6 years, 10 months ago by Alan Knight
Modified:
6 years, 10 months ago
Reviewers:
Emily Fortuna, kevmoo
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Not having this led to failures in the docgen tests because we put the test libraries as being in the package docgen when running tests. Committed: https://code.google.com/p/dart/source/detail?r=32996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M pkg/docgen/lib/docgen.dart View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alan Knight
6 years, 10 months ago (2014-02-25 00:11:01 UTC) #1
Alan Knight
TBR, as this is breaking bots.
6 years, 10 months ago (2014-02-25 00:11:29 UTC) #2
Alan Knight
Committed patchset #1 manually as r32996 (presubmit successful).
6 years, 10 months ago (2014-02-25 00:11:46 UTC) #3
kevmoo
On 2014/02/25 00:11:46, Alan Knight wrote: > Committed patchset #1 manually as r32996 (presubmit successful). ...
6 years, 10 months ago (2014-02-25 00:16:53 UTC) #4
Emily Fortuna
6 years, 10 months ago (2014-02-25 02:05:46 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698