Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 179043004: Allow a wider pub constraint on barback. (Closed)

Created:
6 years, 10 months ago by nweiz
Modified:
6 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow a wider pub constraint on barback. Currently pub is compatible with both barback 0.11.0 and 0.12.0, so its constraint should reflect that. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=33035

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 10 months ago (2014-02-25 01:25:09 UTC) #1
Bob Nystrom
https://codereview.chromium.org/179043004/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart File sdk/lib/_internal/pub/lib/src/barback.dart (right): https://codereview.chromium.org/179043004/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart#newcode41 sdk/lib/_internal/pub/lib/src/barback.dart:41: final earliestSupportedVersion = new Version(0, 11, 0); What's this ...
6 years, 10 months ago (2014-02-25 17:34:01 UTC) #2
nweiz
https://codereview.chromium.org/179043004/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart File sdk/lib/_internal/pub/lib/src/barback.dart (right): https://codereview.chromium.org/179043004/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart#newcode41 sdk/lib/_internal/pub/lib/src/barback.dart:41: final earliestSupportedVersion = new Version(0, 11, 0); On 2014/02/25 ...
6 years, 10 months ago (2014-02-25 20:48:55 UTC) #3
nweiz
On 2014/02/25 20:48:55, nweiz wrote: > https://codereview.chromium.org/179043004/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart > File sdk/lib/_internal/pub/lib/src/barback.dart (right): > > https://codereview.chromium.org/179043004/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart#newcode41 > ...
6 years, 10 months ago (2014-02-25 20:53:01 UTC) #4
nweiz
Committed patchset #2 manually as r33035 (presubmit successful).
6 years, 10 months ago (2014-02-25 20:53:18 UTC) #5
Bob Nystrom
6 years, 10 months ago (2014-02-25 21:48:52 UTC) #6
Message was sent while issue was closed. 
LGTM!

Powered by Google App Engine
This is Rietveld 408576698