Issue 17904009: Hide parent function name in name of closurized function to user.

Issue 17904009: Hide parent function name in name of closurized function to user. (Closed)

Created:
7 years, 6 months ago by regis

Modified:
7 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Hide parent function name in name of closurized function to user (issue 5436). Hide implicit parameter of closure to user. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=24504

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -22 lines)			Patch
M	pkg/unittest/test/instance_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/matchers_minified_test.dart	View	1 2	7 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/unittest/test/matchers_test.dart	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/unittest/test/matchers_unminified_test.dart	View	1 2	7 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/unittest/test/pretty_print_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/resolver.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/17904009/diff/5001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/17904009/diff/5001/runtime/vm/object.h#newcode1334 runtime/vm/object.h:1334: return I find this more readable. Take ...

7 years, 6 months ago (2013-06-27 00:34:38 UTC) #2

regis

Thanks https://codereview.chromium.org/17904009/diff/5001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/17904009/diff/5001/runtime/vm/object.h#newcode1334 runtime/vm/object.h:1334: return On 2013/06/27 00:34:38, Ivan Posva wrote: > ...

7 years, 6 months ago (2013-06-27 00:48:35 UTC) #3

regis

7 years, 6 months ago (2013-06-27 00:49:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r24504 (presubmit successful).

Expand Messages | Collapse Messages