Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 17893008: Refactoring docgen to make it more unit testable. (Closed)

Created:
7 years, 6 months ago by janicejl
Modified:
7 years, 6 months ago
Visibility:
Public.

Description

Refactoring docgen to make it more unit testable. broke up a few other functions to be smaller and only do one thing (mostly). separated documentLibraries into 3 smaller functions that returns things so that it can be unit tested. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=24486

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -29 lines) Patch
M pkg/docgen/lib/docgen.dart View 5 chunks +44 lines, -29 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
janicejl
7 years, 6 months ago (2013-06-26 18:35:48 UTC) #1
Emily Fortuna
lgtm https://codereview.chromium.org/17893008/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/17893008/diff/1/pkg/docgen/lib/docgen.dart#newcode137 pkg/docgen/lib/docgen.dart:137: void analyzeMirrors(MirrorSystem mirrorSystem) { consider renaming to something ...
7 years, 6 months ago (2013-06-26 19:16:43 UTC) #2
janicejl
7 years, 6 months ago (2013-06-26 20:09:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698