Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 178843003: [html5lib] triple slash comment style (Closed)

Created:
6 years, 9 months ago by Jennifer Messerly
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[html5lib] triple slash comment style Also improves ./tools/line_doc_comments.dart to warn about lines >= 80 chars, to make it easier to catch these. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32997

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : remove extra check #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -466 lines) Patch
M pkg/third_party/html5lib/lib/dom.dart View 15 chunks +59 lines, -85 lines 2 comments Download
M pkg/third_party/html5lib/lib/dom_parsing.dart View 1 5 chunks +31 lines, -43 lines 0 comments Download
M pkg/third_party/html5lib/lib/parser.dart View 1 16 chunks +82 lines, -104 lines 0 comments Download
M pkg/third_party/html5lib/lib/parser_console.dart View 2 chunks +7 lines, -11 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/char_encodings.dart View 1 6 chunks +22 lines, -34 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/constants.dart View 1 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/encoding_parser.dart View 7 chunks +14 lines, -22 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/inputstream.dart View 8 chunks +38 lines, -54 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/list_proxy.dart View 2 chunks +5 lines, -7 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/token.dart View 4 chunks +10 lines, -14 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/tokenizer.dart View 7 chunks +22 lines, -36 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/treebuilder.dart View 10 chunks +16 lines, -24 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/utils.dart View 1 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/third_party/html5lib/test/dom_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/third_party/html5lib/test/parser_feature_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/third_party/html5lib/test/parser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/third_party/html5lib/test/support.dart View 3 chunks +5 lines, -9 lines 0 comments Download
M pkg/third_party/html5lib/test/tokenizer_test.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M tools/line_doc_comments.dart View 1 2 2 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
6 years, 9 months ago (2014-02-24 22:37:35 UTC) #1
Jennifer Messerly
https://codereview.chromium.org/178843003/diff/20001/tools/line_doc_comments.dart File tools/line_doc_comments.dart (right): https://codereview.chromium.org/178843003/diff/20001/tools/line_doc_comments.dart#newcode102 tools/line_doc_comments.dart:102: if (oldLine != line && line.length > 80 && ...
6 years, 9 months ago (2014-02-24 22:42:18 UTC) #2
Siggi Cherem (dart-lang)
lgtm! --- only 1 >80 col line below https://codereview.chromium.org/178843003/diff/40001/pkg/third_party/html5lib/lib/dom.dart File pkg/third_party/html5lib/lib/dom.dart (right): https://codereview.chromium.org/178843003/diff/40001/pkg/third_party/html5lib/lib/dom.dart#newcode88 pkg/third_party/html5lib/lib/dom.dart:88: /// ...
6 years, 9 months ago (2014-02-24 23:03:28 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/178843003/diff/40001/pkg/third_party/html5lib/lib/dom.dart File pkg/third_party/html5lib/lib/dom.dart (right): https://codereview.chromium.org/178843003/diff/40001/pkg/third_party/html5lib/lib/dom.dart#newcode88 pkg/third_party/html5lib/lib/dom.dart:88: /// Note that attribute order needs to be stable ...
6 years, 9 months ago (2014-02-25 00:32:08 UTC) #4
Jennifer Messerly
6 years, 9 months ago (2014-02-25 00:36:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r32997 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698