Issue 17878002: Change the timeout handling in the standalone VM to use 64-bit integers

Issue 17878002: Change the timeout handling in the standalone VM to use 64-bit integers (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
floitsch, Ivan Posva

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change the timeout handling in the standalone VM to use 64-bit integers R=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24466

Patch Set 2 : Fix ASSERT and accidental edit #

Total comments: 2

Patch Set 3 : Addressed review comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -18 lines)			Patch
M	runtime/bin/eventhandler_android.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_android.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/bin/eventhandler_linux.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_linux.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/bin/eventhandler_macos.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/bin/eventhandler_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_win.cc	View	1 2	2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! https://codereview.chromium.org/17878002/diff/2001/runtime/bin/eventhandler_win.cc File runtime/bin/eventhandler_win.cc (right): https://codereview.chromium.org/17878002/diff/2001/runtime/bin/eventhandler_win.cc#newcode942 runtime/bin/eventhandler_win.cc:942: ASSERT(millis == kInfinityTimeout || millis >= 0); ASSERT(size_of(int32) ...

7 years, 6 months ago (2013-06-26 13:21:10 UTC) #2

Søren Gjesse

https://codereview.chromium.org/17878002/diff/2001/runtime/bin/eventhandler_win.cc File runtime/bin/eventhandler_win.cc (right): https://codereview.chromium.org/17878002/diff/2001/runtime/bin/eventhandler_win.cc#newcode942 runtime/bin/eventhandler_win.cc:942: ASSERT(millis == kInfinityTimeout || millis >= 0); On 2013/06/26 ...

7 years, 6 months ago (2013-06-26 13:26:32 UTC) #3

Søren Gjesse

Committed patchset #3 manually as r24466 (presubmit successful).

7 years, 6 months ago (2013-06-26 13:33:33 UTC) #4

Ivan Posva

7 years, 6 months ago (2013-06-26 15:29:31 UTC) #5

Message was sent while issue was closed.

On 2013/06/26 13:18:26, Søren Gjesse wrote:

Søren,

What prompted this rewrite?

Thanks,
-Ivan

Expand Messages | Collapse Messages