Issue 178683003: [observe] use consistent comment style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 178683003: [observe] use consistent comment style (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly

Modified:
6 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[observe] use consistent comment style R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32998

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+350 lines, -437 lines)			Patch
M	pkg/observe/lib/html.dart	View	4 chunks	+11 lines, -17 lines	0 comments	Download
M	pkg/observe/lib/observe.dart	View	1 chunk	+71 lines, -73 lines	0 comments	Download
M	pkg/observe/lib/src/bind_property.dart	View	1 chunk	+17 lines, -19 lines	0 comments	Download
M	pkg/observe/lib/src/change_notifier.dart	View	3 chunks	+24 lines, -34 lines	0 comments	Download
M	pkg/observe/lib/src/change_record.dart	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	pkg/observe/lib/src/dirty_check.dart	View	4 chunks	+22 lines, -31 lines	0 comments	Download
M	pkg/observe/lib/src/list_diff.dart	View	4 chunks	+33 lines, -41 lines	0 comments	Download
M	pkg/observe/lib/src/list_path_observer.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/observe/lib/src/metadata.dart	View	1 chunk	+27 lines, -35 lines	0 comments	Download
M	pkg/observe/lib/src/observable.dart	View	6 chunks	+41 lines, -55 lines	0 comments	Download
M	pkg/observe/lib/src/observable_box.dart	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	pkg/observe/lib/src/observable_list.dart	View	2 chunks	+47 lines, -59 lines	0 comments	Download
M	pkg/observe/lib/src/observable_map.dart	View	2 chunks	+19 lines, -23 lines	0 comments	Download
M	pkg/observe/lib/src/to_observable.dart	View	1 chunk	+14 lines, -16 lines	0 comments	Download
M	pkg/observe/lib/transform.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	pkg/observe/lib/transformer.dart	View	5 chunks	+10 lines, -14 lines	0 comments	Download
M	pkg/observe/test/transformer_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

... as promised in a review a while back, this moves pkg:observe to consistent style ...

6 years, 10 months ago (2014-02-24 22:40:46 UTC) #1

Siggi Cherem (dart-lang)

nice. LGTM. you might run into some conflicts with the CL I just submitted. Hope ...

6 years, 10 months ago (2014-02-24 23:49:18 UTC) #2

Jennifer Messerly

6 years, 10 months ago (2014-02-25 00:55:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32998 (presubmit successful).

Expand Messages | Collapse Messages