Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 17857008: Fix and simplify invocation of noSuchMethod on all platforms after the wrong (Closed)

Created:
7 years, 6 months ago by regis
Modified:
7 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix and simplify invocation of noSuchMethod on all platforms after the wrong number (or bad name) of arguments is passed. The frame of the wrong method (the one invoked with the wrong number or name of arguments) is not left on the stack and therefore not visible in the stack trace anymore, which is much cleaner, especially since the leftover frame was not fully initialized. This change was already done on ARM. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=24485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -310 lines) Patch
M runtime/vm/assembler_mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 2 chunks +13 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 4 chunks +8 lines, -56 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 4 chunks +8 lines, -58 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 4 chunks +8 lines, -56 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 5 chunks +25 lines, -67 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 5 chunks +25 lines, -66 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 6 months ago (2013-06-26 18:46:19 UTC) #1
zra
lgtm
7 years, 6 months ago (2013-06-26 19:04:10 UTC) #2
regis
7 years, 6 months ago (2013-06-26 19:58:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24485 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698