Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 17854002: Change the target that we build on the android bot from samples to runtime (Closed)

Created:
7 years, 6 months ago by ricow1
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the target that we build on the android bot from samples to runtime It seems that the sample is broken, do we even support this? R=efortuna@google.com, vsm@google.com, whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/bots/android.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ricow1
7 years, 6 months ago (2013-06-26 10:34:36 UTC) #1
Bill Hesse
LGTM. I have gotten the runtime target building, but it decays unless it is on ...
7 years, 6 months ago (2013-06-26 10:39:38 UTC) #2
Emily Fortuna
lgtm, but also adding Graham. Graham and Vijay have been looking at this stuff much ...
7 years, 6 months ago (2013-06-26 16:21:32 UTC) #3
gram
On 2013/06/26 16:21:32, Emily Fortuna wrote: > lgtm, but also adding Graham. Graham and Vijay ...
7 years, 6 months ago (2013-06-26 17:09:56 UTC) #4
gram
On 2013/06/26 17:09:56, gram wrote: > On 2013/06/26 16:21:32, Emily Fortuna wrote: > > lgtm, ...
7 years, 6 months ago (2013-06-26 23:43:44 UTC) #5
vsm
lgtm
7 years, 6 months ago (2013-06-27 02:39:28 UTC) #6
ricow1
Committed patchset #1 manually as r24507 (presubmit successful).
7 years, 5 months ago (2013-06-27 05:59:19 UTC) #7
Bill Hesse
7 years, 5 months ago (2013-06-27 08:09:45 UTC) #8
Message was sent while issue was closed.
Yes, change https://codereview.chromium.org/17860002/ should fix the runtime
build, and turn it green.

Powered by Google App Engine
This is Rietveld 408576698