Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 17851004: One event handler for all isolates (Closed)

Created:
7 years, 6 months ago by Søren Gjesse
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

One event ahndler for all isolates BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25082

Patch Set 1 #

Patch Set 2 : Handle timeouts for all isolates. #

Patch Set 3 : Clean up timeout queue to explicit TimeoutQueue class. #

Patch Set 4 : Windows impl. #

Patch Set 5 : Add Android and Mac impl. #

Patch Set 6 : Remove unused line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -78 lines) Patch
M runtime/bin/eventhandler.h View 1 2 3 4 2 chunks +57 lines, -3 lines 0 comments Download
M runtime/bin/eventhandler.cc View 1 2 3 4 5 3 chunks +52 lines, -20 lines 0 comments Download
M runtime/bin/eventhandler_android.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/eventhandler_android.cc View 1 2 3 4 3 chunks +9 lines, -11 lines 0 comments Download
M runtime/bin/eventhandler_linux.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
M runtime/bin/eventhandler_macos.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 2 3 4 3 chunks +9 lines, -11 lines 0 comments Download
M runtime/bin/eventhandler_win.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/eventhandler_win.cc View 1 2 3 4 chunks +7 lines, -10 lines 0 comments Download
M runtime/bin/isolate_data.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Anders Johnsen
Bill, please take a look at this Linux-only change. I'm using a linked-list to keep ...
7 years, 5 months ago (2013-07-15 15:01:51 UTC) #1
Bill Hesse
lgtm Looks great! If the linked-list becomes too slow, then a hashtable can be used.
7 years, 5 months ago (2013-07-15 17:38:57 UTC) #2
Anders Johnsen
Bill, please take another look. I've isolated the queue to an explicit list, making it ...
7 years, 5 months ago (2013-07-15 18:50:09 UTC) #3
Bill Hesse
lgtm Good.
7 years, 5 months ago (2013-07-16 08:27:28 UTC) #4
Anders Johnsen
PTAL, ready for final review now.
7 years, 5 months ago (2013-07-16 11:13:05 UTC) #5
Bill Hesse
LGTM.
7 years, 5 months ago (2013-07-16 15:01:02 UTC) #6
Anders Johnsen
7 years, 5 months ago (2013-07-17 07:26:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 manually as r25082 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698