Issue 17833003: Add directory-listing to VirtualDirectory.

Issue 17833003: Add directory-listing to VirtualDirectory. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen

Modified:
7 years, 5 months ago

Reviewers:
Søren Gjesse, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add directory-listing to VirtualDirectory. BUG= R=sgjesse@google.com, whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24584

Patch Set 3 : More tests and custom handler. #

Total comments: 4

Patch Set 4 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -17 lines)			Patch
	M	pkg/http_server/lib/src/virtual_directory.dart	View	1 2 3	6 chunks	+114 lines, -17 lines	0 comments	Download
	M	pkg/http_server/test/virtual_directory_test.dart	View	1 2	1 chunk	+111 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/17833003/diff/1/pkg/http_server/lib/src/virtual_directory.dart File pkg/http_server/lib/src/virtual_directory.dart (right): https://codereview.chromium.org/17833003/diff/1/pkg/http_server/lib/src/virtual_directory.dart#newcode205 pkg/http_server/lib/src/virtual_directory.dart:205: void _serveDirectory(Directory dir, HttpRequest request) { Maybe add ...

7 years, 6 months ago (2013-06-26 10:19:11 UTC) #2

Bill Hesse

lgtm https://codereview.chromium.org/17833003/diff/8001/pkg/http_server/lib/src/virtual_directory.dart File pkg/http_server/lib/src/virtual_directory.dart (right): https://codereview.chromium.org/17833003/diff/8001/pkg/http_server/lib/src/virtual_directory.dart#newcode136 pkg/http_server/lib/src/virtual_directory.dart:136: .canonicalize(); Nit: Break line at = ? https://codereview.chromium.org/17833003/diff/8001/pkg/http_server/lib/src/virtual_directory.dart#newcode282 ...

7 years, 5 months ago (2013-06-28 12:42:26 UTC) #4

Anders Johnsen

https://codereview.chromium.org/17833003/diff/8001/pkg/http_server/lib/src/virtual_directory.dart File pkg/http_server/lib/src/virtual_directory.dart (right): https://codereview.chromium.org/17833003/diff/8001/pkg/http_server/lib/src/virtual_directory.dart#newcode136 pkg/http_server/lib/src/virtual_directory.dart:136: .canonicalize(); On 2013/06/28 12:42:26, Bill Hesse wrote: > Nit: ...

7 years, 5 months ago (2013-06-28 12:49:36 UTC) #5

Anders Johnsen

7 years, 5 months ago (2013-06-28 12:49:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r24584 (presubmit successful).

Expand Messages | Collapse Messages