Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 178303009: [html5lib] api updates: localName (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -195 lines) Patch
M pkg/polymer/lib/src/build/linter.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/third_party/html5lib/lib/dom.dart View 1 2 3 19 chunks +84 lines, -48 lines 0 comments Download
M pkg/third_party/html5lib/lib/dom_parsing.dart View 4 chunks +22 lines, -6 lines 0 comments Download
M pkg/third_party/html5lib/lib/parser.dart View 1 2 49 chunks +96 lines, -86 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/tokenizer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/third_party/html5lib/lib/src/treebuilder.dart View 1 12 chunks +24 lines, -23 lines 0 comments Download
M pkg/third_party/html5lib/test/parser_feature_test.dart View 1 2 3 3 chunks +31 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
this all started with adding localName (instead of tagName) and moving it to Element, but ...
6 years, 10 months ago (2014-02-25 02:22:15 UTC) #1
Siggi Cherem (dart-lang)
lgtm
6 years, 10 months ago (2014-02-25 04:03:24 UTC) #2
Jennifer Messerly
6 years, 10 months ago (2014-02-25 04:07:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r33004 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698