Add support for configuration presets.

Add support for configuration presets.

Closes #83

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/f6b4d1c944648e26ba2887a47d092b0a35711da9

[kevmoo, 2016-03-10 17:09:39]

Also: add a preset for no browser on this package? As an example?

https://codereview.chromium.org/1782473005/diff/1/doc/package_config.md
File doc/package_config.md (right):

https://codereview.chromium.org/1782473005/diff/1/doc/package_config.md#newco...
doc/package_config.md:428: presets:
Is there supposed to be a usage of `add_presets` here?

https://codereview.chromium.org/1782473005/diff/1/lib/src/runner/configuratio...
File lib/src/runner/configuration.dart (right):

https://codereview.chromium.org/1782473005/diff/1/lib/src/runner/configuratio...
lib/src/runner/configuration.dart:393: /// Returns [input] or an empty map.
clarify that the returned value in not modifiable?

[kevmoo, 2016-03-10 17:09:50]

...otherwise, LGTM

[nweiz, 2016-03-10 20:40:07]

Code review changes

[nweiz, 2016-03-10 20:41:20]

> Also: add a preset for no browser on this package? As an example?

I'd rather keep the test config restricted to stuff that's actually useful when
developing tests. A preset that makes "-P browser" identical to "-t browser"
isn't all that useful. Examples belong in the documentation.

https://codereview.chromium.org/1782473005/diff/1/doc/package_config.md
File doc/package_config.md (right):

https://codereview.chromium.org/1782473005/diff/1/doc/package_config.md#newco...
doc/package_config.md:428: presets:
On 2016/03/10 17:09:39, kevmoo wrote:
> Is there supposed to be a usage of `add_presets` here?

Done.

https://codereview.chromium.org/1782473005/diff/1/lib/src/runner/configuratio...
File lib/src/runner/configuration.dart (right):

https://codereview.chromium.org/1782473005/diff/1/lib/src/runner/configuratio...
lib/src/runner/configuration.dart:393: /// Returns [input] or an empty map.
On 2016/03/10 17:09:39, kevmoo wrote:
> clarify that the returned value in not modifiable?

Done.

[nweiz, 2016-03-10 20:41:43]

Description was changed from

==========
Add support for configuration presets.

Closes #83

R=kevmoo@google.com
==========

to

==========
Add support for configuration presets.

Closes #83

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/test/commit/f6b4d1c944648e26ba2887a47d092b0a3571...
==========

[nweiz, 2016-03-10 20:41:44]

Committed patchset #2 (id:20001) manually as
f6b4d1c944648e26ba2887a47d092b0a35711da9 (presubmit successful).