Better inlining of type tests.

Better inlining of type tests.

The optimizing compiler can replace a type test with a cid-comparison
under certain conditions. This CL translates the instance-of call
into a inline comparison in the optimizer and not - as previously -
in the code generator. This results in better generated code for
like

if (x is y) {...}

when y does not have sub-classes and does not have type arguments.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33231

[regis, 2014-03-03 17:54:25]

LGTM

https://codereview.chromium.org/178193020/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/178193020/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:3565: // Requires CHA, which can be applied
in optimized code only,
Comment ending with a comma.

[Florian Schneider, 2014-03-03 18:09:05]

Committed patchset #1 manually as r33231 (presubmit successful).

[Florian Schneider, 2014-03-03 18:09:50]

https://codereview.chromium.org/178193020/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/178193020/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:3565: // Requires CHA, which can be applied
in optimized code only,
On 2014/03/03 17:54:25, regis wrote:
> Comment ending with a comma.

Done.

[srdjan, 2014-03-03 18:13:24]

DBC

https://codereview.chromium.org/178193020/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/178193020/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:3623: if (TypeCheckAsClassEquality(type)) {
For next CL eventually: how about supporting a set of cid-s, e.g., if the class
has only a small number of subclasses?

[Florian Schneider, 2014-03-04 10:22:52]

https://codereview.chromium.org/178193020/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/178193020/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:3623: if (TypeCheckAsClassEquality(type)) {
On 2014/03/03 18:13:25, srdjan wrote:
> For next CL eventually: how about supporting a set of cid-s, e.g., if the
class
> has only a small number of subclasses?

Definitely.