Issue 178183002: Fixing test status for code_transformers under pkgbuild.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 178183002: Fixing test status for code_transformers under pkgbuild. (Closed)

Created:
6 years, 10 months ago by blois

Modified:
6 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang), scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing test status for code_transformers under pkgbuild. Not sure why this started passing, but it is. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=32973

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	pkg/pkgbuild.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r32973 (presubmit successful).

6 years, 10 months ago (2014-02-24 17:24:50 UTC) #2

blois

On 2014/02/24 17:35:30, Siggi Cherem (dart-lang) wrote: > lgtm For closure- reason it started passing ...

6 years, 10 months ago (2014-02-24 18:51:47 UTC) #4

Siggi Cherem (dart-lang)

6 years, 10 months ago (2014-02-24 19:00:31 UTC) #5

Message was sent while issue was closed.

On 2014/02/24 18:51:47, blois wrote:
> On 2014/02/24 17:35:30, Siggi Cherem (dart-lang) wrote:
> > lgtm
> 
> For closure- reason it started passing was because the Analyzer package was
> uploaded to pub. Once this happened then the test started passing.

I plan to meet later this week with Rico and Martin, I'll bring this up to see
if we can make this better.

Expand Messages | Collapse Messages