Issue 17770003: Add --deoptimization_counter_inlining_threshold=10 that stops inlining in a method that has reached…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17770003: Add --deoptimization_counter_inlining_threshold=10 that stops inlining in a method that has reached… (Closed)

Created:
7 years, 6 months ago by srdjan

Modified:
7 years, 5 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add --deoptimization_counter_inlining_threshold=10 that stops inlining in a method that has reached it. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=24519

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -15 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2 3 4 5 6	2 chunks	+21 lines, -14 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1 2 3 4 5 6	2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 2 3 4 5 6	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

I would rather disable loop invariant code motion after a some threshold for now. Inlining ...

7 years, 6 months ago (2013-06-26 13:23:10 UTC) #2

srdjan

PTAL Added flag --stop_on_excessive_deoptimization=false to locate performance problems caused by excessive deoptimization. Added --deoptimization_counter_licm_threshold=8 to ...

7 years, 6 months ago (2013-06-26 18:04:08 UTC) #3

srdjan

7 years, 5 months ago (2013-06-27 15:26:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #7 manually as r24519 (presubmit successful).

Expand Messages | Collapse Messages