Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 17766005: Fix and simplify invocation of noSuchMethod on ARM after the wrong number of (Closed)

Created:
7 years, 6 months ago by regis
Modified:
7 years, 6 months ago
Reviewers:
zra, srdjan
CC:
reviews_dartlang.org, srdjan, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix and simplify invocation of noSuchMethod on ARM after the wrong number of arguments is passed. The frame of the wrong method (the one invoked with the wrong number of arguments) is not left on the stack and therefore not visible in the stack trace anymore, which is much cleaner, especially since the leftover frame was not fully initialized. Note: We should simplify this on other platforms as well. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=24475

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -62 lines) Patch
M runtime/vm/flow_graph_compiler_arm.cc View 1 4 chunks +8 lines, -60 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
regis
7 years, 6 months ago (2013-06-26 02:10:20 UTC) #1
zra
lgtm Just to make sure, there will still be enough position information available in the ...
7 years, 6 months ago (2013-06-26 16:13:19 UTC) #2
regis
On 2013/06/26 16:13:19, zra wrote: > lgtm > > Just to make sure, there will ...
7 years, 6 months ago (2013-06-26 16:29:49 UTC) #3
regis
Committed patchset #2 manually as r24475 (presubmit successful).
7 years, 6 months ago (2013-06-26 16:31:56 UTC) #4
srdjan
7 years, 6 months ago (2013-06-26 17:26:19 UTC) #5
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698