Fix error-checking when calling timerfd_create.

Fix error-checking when calling timerfd_create.

BUG=https://code.google.com/p/dart/issues/detail?id=17051
R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32960

[kasperl, 2014-02-24 12:04:15]

https://codereview.chromium.org/177643002/diff/1/runtime/bin/eventhandler_lin...
File runtime/bin/eventhandler_linux.cc (right):

https://codereview.chromium.org/177643002/diff/1/runtime/bin/eventhandler_lin...
runtime/bin/eventhandler_linux.cc:67: FATAL("Failed creating epoll file
descriptor");
Add errno printing here too?

https://codereview.chromium.org/177643002/diff/1/runtime/bin/eventhandler_lin...
runtime/bin/eventhandler_linux.cc:72: FATAL1("Failed creating timerfd file
descriptor: %i\n", errno);
Is the \n necessary? You don't pass it to the FATAL call above.

[Anders Johnsen, 2014-02-24 12:10:42]

https://codereview.chromium.org/177643002/diff/1/runtime/bin/eventhandler_lin...
File runtime/bin/eventhandler_linux.cc (right):

https://codereview.chromium.org/177643002/diff/1/runtime/bin/eventhandler_lin...
runtime/bin/eventhandler_linux.cc:67: FATAL("Failed creating epoll file
descriptor");
On 2014/02/24 12:04:15, kasperl wrote:
> Add errno printing here too?

Done.

https://codereview.chromium.org/177643002/diff/1/runtime/bin/eventhandler_lin...
runtime/bin/eventhandler_linux.cc:72: FATAL1("Failed creating timerfd file
descriptor: %i\n", errno);
On 2014/02/24 12:04:15, kasperl wrote:
> Is the \n necessary? You don't pass it to the FATAL call above.

You're right. Fixed.

[Anders Johnsen, 2014-02-24 12:17:35]

PTAL

[kasperl, 2014-02-24 12:25:16]

Maybe the other platforms (android, macos) should be cleaned up similarly?

[kasperl, 2014-02-24 12:25:23]

LGTM.

[Anders Johnsen, 2014-02-24 12:45:22]

Committed patchset #2 manually as r32960 (presubmit successful).

[Søren Gjesse, 2014-02-24 13:55:30]

lgtm

[Søren Gjesse, 2014-02-24 13:56:37]

On 2014/02/24 13:55:30, Søren Gjesse wrote:
> lgtm

Shouldn't this be merged into 1.2?