Issue 17745007: Getting docgen to work with the SDK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17745007: Getting docgen to work with the SDK. (Closed)

Created:
7 years, 6 months ago by janicejl

Modified:
7 years, 6 months ago

Reviewers:
Tate Mandel, Emily Fortuna, Andrei Mouravski

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Getting docgen to work with the SDK. R=amouravski@google.com Committed: https://code.google.com/p/dart/source/detail?r=24477

Patch Set 2 : #

Total comments: 3

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	pkg/docgen/bin/docgen.dart	View	1	1 chunk	+2 lines, -0 lines	1 comment	Download
	M	pkg/docgen/lib/docgen.dart	View		4 chunks	+18 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

Fix a few nits, then lgtm. https://codereview.chromium.org/17745007/diff/3001/pkg/docgen/bin/docgen.dart File pkg/docgen/bin/docgen.dart (right): https://codereview.chromium.org/17745007/diff/3001/pkg/docgen/bin/docgen.dart#newcode55 pkg/docgen/bin/docgen.dart:55: parser.addFlag('parse-sdk', More help ...

7 years, 6 months ago (2013-06-26 04:42:11 UTC) #2

janicejl

7 years, 6 months ago (2013-06-26 17:04:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r24477 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17745007: Getting docgen to work with the SDK. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages