Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1774183002: Throw a StateError in case no model was registered for a given kind (Closed)

Created:
4 years, 9 months ago by kustermann
Modified:
4 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/gcloud.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Throw a StateError in case no model was registered for a given kind Committed: https://github.com/dart-lang/gcloud/commit/59f1bf5f36bcedd629d0532ea1de24ea77c63063

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/db/model_db_impl.dart View 1 1 chunk +6 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kustermann
4 years, 9 months ago (2016-03-08 17:37:23 UTC) #2
kustermann
Will TBR this for a customer.
4 years, 9 months ago (2016-03-08 17:38:42 UTC) #3
kustermann
Committed patchset #2 (id:20001) manually as 59f1bf5f36bcedd629d0532ea1de24ea77c63063 (presubmit successful).
4 years, 9 months ago (2016-03-08 17:38:54 UTC) #5
Søren Gjesse
4 years, 9 months ago (2016-03-09 08:19:31 UTC) #6
Message was sent while issue was closed.
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698