Revise spec to agree with implementations for meaning of getter/variable and setter references. Whi…

Revise spec to agree with implementations for meaning of getter/variable and setter references. While the actual difference were only in a few odd cases, the new text should also be clearer.

R=hausner@google.com, lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33287

[gbracha, 2014-02-27 21:30:48]

Hopefully everyone can agree that this is the behavior that is actually
implemented.

[hausner, 2014-02-27 22:23:31]

LGTM w/questions.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3385: If $d$ is the declaration of a local
variable, the expression $e$ is evaluated to an object $o$. Then, the variable
$v$ is bound to $o$ unless $v$ is \FINAL{}, in which case a dynamic error
occurs.
Does "dynamic error occurs" imply that the error is thrown? If so, ok.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3388: If $d$ is the declaration of a library
variable, top level getter or top level setter, the expression $e$ is evaluated
to an object $o$. Then the setter $v=$ is invoked with its formal parameter
bound to $o$. The value of the assignment expression is $o$.
Does this imply that if the setter does not exist, a NoSuchMethodError is
thrown?

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3390: Otherwise, if $d$ is the declaration of a
static variable, static getter or static setter in class $C$, then the
assignment is equivalent to the assignment \code{$C.v$ = $e$}.
ditto.

[hausner, 2014-02-27 22:23:43]

LGTM w/questions.

[Lasse Reichstein Nielsen, 2014-03-04 11:41:43]

lgtm

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3385: If $d$ is the declaration of a local
variable, the expression $e$ is evaluated to an object $o$. Then, the variable
$v$ is bound to $o$ unless $v$ is \FINAL{}, in which case a dynamic error
occurs.
... unless v is final or const.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3388: If $d$ is the declaration of a library
variable, top level getter or top level setter, the expression $e$ is evaluated
to an object $o$. Then the setter $v=$ is invoked with its formal parameter
bound to $o$. The value of the assignment expression is $o$.
Even if it does, it's not clear enough, and could do with more explanation of
what happens if there is no 'v=' declaration (a getter only, final or const
top-level variable).

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3390: Otherwise, if $d$ is the declaration of a
static variable, static getter or static setter in class $C$, then the
assignment is equivalent to the assignment \code{$C.v$ = $e$}.
This is a rewrite, so it should be fine. The entire behavior should be handled
for C.v=e, including C not having a 'v=' setter.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3939: \item If $d$ is a type parameter $T$, then
the value of $e$ is the value of the actual type argument corresponding to $T$
that was  passed to the generative constructor that created the current binding
of \THIS{}. If, however, $e$ occurs inside a static member, a compile-time error
occurs.
If T occurs inside the initializers of a generative constructor, there is no
`this`, but the type parameters are still available.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:4846: A library consists of (a possibly empty)
set of imports, a set of exports,  and a set of top-level declarations. A
top-level declaration is either a class (\ref{classes}), a type alias
declaration (\ref{typedef}), a function (\ref{functions}) or a variable
declaration (\ref{variables}). The members of a library $L$ are those top level
declarations given within $L$.
Are getters and setters included in functions or variables?

[gbracha, 2014-03-04 18:37:27]

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3385: If $d$ is the declaration of a local
variable, the expression $e$ is evaluated to an object $o$. Then, the variable
$v$ is bound to $o$ unless $v$ is \FINAL{}, in which case a dynamic error
occurs.
On 2014/02/27 22:23:32, hausner wrote:
> Does "dynamic error occurs" imply that the error is thrown? If so, ok.

Yes.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3385: If $d$ is the declaration of a local
variable, the expression $e$ is evaluated to an object $o$. Then, the variable
$v$ is bound to $o$ unless $v$ is \FINAL{}, in which case a dynamic error
occurs.
On 2014/03/04 11:41:43, Lasse Reichstein Nielsen wrote:
> ... unless v is final or const.

Added that, though strictly speaking that is redundant, since a const variable
is always implicitly final as stated in section 5.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3388: If $d$ is the declaration of a library
variable, top level getter or top level setter, the expression $e$ is evaluated
to an object $o$. Then the setter $v=$ is invoked with its formal parameter
bound to $o$. The value of the assignment expression is $o$.
On 2014/02/27 22:23:32, hausner wrote:
> Does this imply that if the setter does not exist, a NoSuchMethodError is
> thrown?

Yes.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3388: If $d$ is the declaration of a library
variable, top level getter or top level setter, the expression $e$ is evaluated
to an object $o$. Then the setter $v=$ is invoked with its formal parameter
bound to $o$. The value of the assignment expression is $o$.
On 2014/03/04 11:41:43, Lasse Reichstein Nielsen wrote:
> Even if it does, it's not clear enough, and could do with more explanation of
> what happens if there is no 'v=' declaration (a getter only, final or const
> top-level variable).

I should probably add some examples.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3390: Otherwise, if $d$ is the declaration of a
static variable, static getter or static setter in class $C$, then the
assignment is equivalent to the assignment \code{$C.v$ = $e$}.
On 2014/02/27 22:23:32, hausner wrote:
> ditto.

And yes again.

https://codereview.chromium.org/177283007/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:4846: A library consists of (a possibly empty)
set of imports, a set of exports,  and a set of top-level declarations. A
top-level declaration is either a class (\ref{classes}), a type alias
declaration (\ref{typedef}), a function (\ref{functions}) or a variable
declaration (\ref{variables}). The members of a library $L$ are those top level
declarations given within $L$.
On 2014/03/04 11:41:43, Lasse Reichstein Nielsen wrote:
> Are getters and setters included in functions or variables?

In functions. Variables implicitly define getters and sometimes setters.

[gbracha, 2014-03-04 18:37:45]

Committed patchset #2 manually as r33287 (presubmit successful).