Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 176893003: Only use one timer to handle HttpServer::idleTimeout. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen
Modified:
6 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Only use one timer to handle HttpServer::idleTimeout. This makes us avoid a lot of timer allocations/cancels by default. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32965

Patch Set 1 #

Total comments: 4

Patch Set 2 : Cleanup and document #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -34 lines) Patch
M sdk/lib/io/http.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 12 chunks +63 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
6 years, 10 months ago (2014-02-24 13:45:44 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/176893003/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/176893003/diff/1/sdk/lib/io/http_impl.dart#newcode1905 sdk/lib/io/http_impl.dart:1905: final Uint8List _headersBuffer = new Uint8List(_HEADERS_BUFFER_SIZE); Why the ...
6 years, 10 months ago (2014-02-24 14:14:35 UTC) #2
Anders Johnsen
https://codereview.chromium.org/176893003/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/176893003/diff/1/sdk/lib/io/http_impl.dart#newcode1905 sdk/lib/io/http_impl.dart:1905: final Uint8List _headersBuffer = new Uint8List(_HEADERS_BUFFER_SIZE); On 2014/02/24 14:14:35, ...
6 years, 10 months ago (2014-02-24 14:35:10 UTC) #3
Anders Johnsen
6 years, 10 months ago (2014-02-24 14:35:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r32965 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698