Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 176883023: Revert "Dart2js testing: Add prefix files when running dart2js output on d8 or jsshell." (Closed)

Created:
6 years, 9 months ago by Bill Hesse
Modified:
6 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Revert "Dart2js testing: Add prefix files when running dart2js output on d8 or jsshell." This reverts r33369. A relative path is failing. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=33372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -45 lines) Patch
D sdk/lib/_internal/lib/preambles/d8.js View 1 chunk +0 lines, -5 lines 0 comments Download
D sdk/lib/_internal/lib/preambles/jsshell.js View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 7 chunks +2 lines, -24 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 3 chunks +0 lines, -10 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
6 years, 9 months ago (2014-03-06 13:27:42 UTC) #1
ahe
lgtm
6 years, 9 months ago (2014-03-06 13:30:27 UTC) #2
Bill Hesse
6 years, 9 months ago (2014-03-06 13:32:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698