Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 176873015: update client to use channel rather than socket (Closed)

Created:
6 years, 10 months ago by danrubel
Modified:
6 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

update client to use channel rather than socket BUG= R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=33080

Patch Set 1 #

Patch Set 2 : move request #

Total comments: 2

Patch Set 3 : use common json encoder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M pkg/analysis_server/lib/src/analysis_manager.dart View 1 3 chunks +5 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/channel.dart View 1 2 3 chunks +14 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
6 years, 10 months ago (2014-02-26 17:17:03 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/176873015/diff/20001/pkg/analysis_server/lib/src/channel.dart File pkg/analysis_server/lib/src/channel.dart (right): https://codereview.chromium.org/176873015/diff/20001/pkg/analysis_server/lib/src/channel.dart#newcode71 pkg/analysis_server/lib/src/channel.dart:71: JsonEncoder encoder = const JsonEncoder(null); Should we create ...
6 years, 10 months ago (2014-02-26 17:50:47 UTC) #2
danrubel
https://codereview.chromium.org/176873015/diff/20001/pkg/analysis_server/lib/src/channel.dart File pkg/analysis_server/lib/src/channel.dart (right): https://codereview.chromium.org/176873015/diff/20001/pkg/analysis_server/lib/src/channel.dart#newcode71 pkg/analysis_server/lib/src/channel.dart:71: JsonEncoder encoder = const JsonEncoder(null); On 2014/02/26 17:50:47, Brian ...
6 years, 10 months ago (2014-02-26 20:10:01 UTC) #3
danrubel
6 years, 10 months ago (2014-02-26 20:11:20 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r33080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698