Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 17681003: Restore adoptNode and importNode to dart:html (Closed)

Created:
7 years, 6 months ago by Jennifer Messerly
Modified:
7 years, 6 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Restore adoptNode and importNode to dart:html http://dom.spec.whatwg.org/#dom-document-importnode These seem more relevant in a <template>/ShadowRoot world. In particular I wanted to port an MDV test that uses adoptNode. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=24423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M tests/html/document_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
7 years, 6 months ago (2013-06-25 17:48:55 UTC) #1
blois
lgtm
7 years, 6 months ago (2013-06-25 18:01:21 UTC) #2
Jennifer Messerly
7 years, 6 months ago (2013-06-25 18:02:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698