Add runAsync interceptor.

Add runAsync interceptor.

BUG= http://dartbug.com/11279
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24470

[Lasse Reichstein Nielsen, 2013-06-26 09:24:29]

lgtm

https://codereview.chromium.org/17672002/diff/4001/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/17672002/diff/4001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:83: * Execute [fun] in `this` zone.
"fun" is untraditional naming: either "action" or just "f".
It's not funny!

Add "and return [fun]'s return value." (which I assume it does, since there is
no "void" return type).

https://codereview.chromium.org/17672002/diff/4001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:508: * [onDone] (if non-null) is invoked when the zone
has no more outstanding
[onDone] -> The [onDone] callback
(avoid initial lower-case letter).

https://codereview.chromium.org/17672002/diff/4001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:511: * [onRunAsync] (if non-null) is invoked when the
[body] executes [runAsync].
Ditto.

https://codereview.chromium.org/17672002/diff/4001/tests/lib/async/intercept_...
File tests/lib/async/intercept_run_async1_test.dart (right):

https://codereview.chromium.org/17672002/diff/4001/tests/lib/async/intercept_...
tests/lib/async/intercept_run_async1_test.dart:12: throw "Unexpected
invocation.";
Expect.fail("Unexpected invocation.");

You imported it, so you might as well use iut.

https://codereview.chromium.org/17672002/diff/4001/tests/lib/async/intercept_...
File tests/lib/async/intercept_run_async2_test.dart (right):

https://codereview.chromium.org/17672002/diff/4001/tests/lib/async/intercept_...
tests/lib/async/intercept_run_async2_test.dart:25: main() {
No receiveport?

[floitsch, 2013-06-26 12:22:56]

https://codereview.chromium.org/17672002/diff/4001/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/17672002/diff/4001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:83: * Execute [fun] in `this` zone.
On 2013/06/26 09:24:29, Lasse Reichstein Nielsen wrote:
> "fun" is untraditional naming: either "action" or just "f".
> It's not funny!
> 
> Add "and return [fun]'s return value." (which I assume it does, since there is
> no "void" return type).

Done.

https://codereview.chromium.org/17672002/diff/4001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:508: * [onDone] (if non-null) is invoked when the zone
has no more outstanding
On 2013/06/26 09:24:29, Lasse Reichstein Nielsen wrote:
> [onDone] -> The [onDone] callback
> (avoid initial lower-case letter).

Done.

https://codereview.chromium.org/17672002/diff/4001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:511: * [onRunAsync] (if non-null) is invoked when the
[body] executes [runAsync].
On 2013/06/26 09:24:29, Lasse Reichstein Nielsen wrote:
> Ditto.

Done.

https://codereview.chromium.org/17672002/diff/4001/tests/lib/async/intercept_...
File tests/lib/async/intercept_run_async1_test.dart (right):

https://codereview.chromium.org/17672002/diff/4001/tests/lib/async/intercept_...
tests/lib/async/intercept_run_async1_test.dart:12: throw "Unexpected
invocation.";
On 2013/06/26 09:24:29, Lasse Reichstein Nielsen wrote:
> Expect.fail("Unexpected invocation.");
> 
> You imported it, so you might as well use iut.

Done.

https://codereview.chromium.org/17672002/diff/4001/tests/lib/async/intercept_...
File tests/lib/async/intercept_run_async2_test.dart (right):

https://codereview.chromium.org/17672002/diff/4001/tests/lib/async/intercept_...
tests/lib/async/intercept_run_async2_test.dart:25: main() {
On 2013/06/26 09:24:29, Lasse Reichstein Nielsen wrote:
> No receiveport?

Not needed. Added comment.

[floitsch, 2013-06-26 14:41:19]

Committed patchset #4 manually as r24470 (presubmit successful).