Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 17646002: Use call counts to determine which static calls to inline. (Closed)

Created:
7 years, 6 months ago by srdjan
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use call counts to determine which static calls to inline. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=24436

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -38 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 9 chunks +18 lines, -9 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 6 chunks +69 lines, -27 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
srdjan
7 years, 6 months ago (2013-06-24 23:31:37 UTC) #1
srdjan
The benchmark results look strange: +70% on Box2DBench, -47% ImagingGaussianBlurOnce, http://108.170.219.0:8080/Comparison#targetA%3Ddart%3BmachineTypeA%3Dlinux-ia32%3BrevisionA%3D24374%3BpatchA%3Dsrdjan-i1b2%3BtargetB%3Ddart%3BmachineTypeB%3Dlinux-ia32%3BrevisionB%3D24374%3BpatchB%3DNone http://108.170.219.0:8080/Comparison#targetA%3Ddart%3BmachineTypeA%3Dlinux-x64%3BrevisionA%3D24374%3BpatchA%3Dsrdjan-i1b2%3BtargetB%3Ddart%3BmachineTypeB%3Dlinux-x64%3BrevisionB%3D24374%3BpatchB%3DNone
7 years, 6 months ago (2013-06-24 23:50:18 UTC) #2
Florian Schneider
LGTM. I'd experiment with changing the thresholds since there are now less static call sites ...
7 years, 6 months ago (2013-06-25 08:48:32 UTC) #3
srdjan
Committed patchset #2 manually as r24436 (presubmit successful).
7 years, 6 months ago (2013-06-25 22:12:58 UTC) #4
srdjan
7 years, 6 months ago (2013-06-25 22:13:21 UTC) #5
Message was sent while issue was closed.
Regression (and improvement) caused by bug in program: fixed with r24433.

Powered by Google App Engine
This is Rietveld 408576698