Issue 17644005: Don't report problem when call 'call()' of Function.

Issue 17644005: Don't report problem when call 'call()' of Function. (Closed)

Created:
7 years, 6 months ago by scheglov

Modified:
7 years, 6 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't report problem when call 'call()' of Function. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24420

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -1 line)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	1 chunk	+6 lines, -0 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/17644005/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java (right): https://codereview.chromium.org/17644005/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java#newcode832 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:832: if (targetType.isDartCoreFunction() && CALL_METHOD_NAME.equals(methodName.getName())) { It is possible ...

7 years, 6 months ago (2013-06-25 13:58:22 UTC) #2

jwren

On 2013/06/25 13:58:22, Brian Wilkerson wrote: > LGTM > > https://codereview.chromium.org/17644005/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java > File > editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java ...

7 years, 6 months ago (2013-06-25 16:19:13 UTC) #3

scheglov

Committed patchset #1 manually as r24420 (presubmit successful).

7 years, 6 months ago (2013-06-25 16:28:23 UTC) #4

scheglov

7 years, 6 months ago (2013-06-25 16:28:51 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/17644005/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
(right):

https://codereview.chromium.org/17644005/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:832:
if (targetType.isDartCoreFunction() &&
CALL_METHOD_NAME.equals(methodName.getName())) {
On 2013/06/25 13:58:22, Brian Wilkerson wrote:
> It is possible for targetType to be null at this point, so we should guard
> against that case.

Done.

Expand Messages | Collapse Messages