Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 17638007: Create LinkExceptions using the right arguments, in dart:io. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Create LinkExceptions using the right arguments, in dart:io. BUG=https://code.google.com/p/dart/issues/detail?id=11310 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24380

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M sdk/lib/io/link.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/link_test.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 6 months ago (2013-06-25 05:36:48 UTC) #1
Søren Gjesse
lgtm Can we add a regression test?
7 years, 6 months ago (2013-06-25 06:21:29 UTC) #2
Anders Johnsen
Done.
7 years, 6 months ago (2013-06-25 06:27:19 UTC) #3
Anders Johnsen
7 years, 6 months ago (2013-06-25 06:28:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24380 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698