Issue 17633008: Simplify close functionality in the browser controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17633008: Simplify close functionality in the browser controller. (Closed)

Created:
7 years, 6 months ago by ricow1

Modified:
7 years, 6 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Simplify close functionality in the browser controller. Add a done future that can be used by users to determine if a browser crashes. This future is the same we return from the close call. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=24395

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -37 lines)			Patch
	M	tools/testing/dart/browser_controller.dart	View		6 chunks	+27 lines, -37 lines	0 comments	Download

Total messages: 3 (0 generated)

ricow1

7 years, 6 months ago (2013-06-25 11:35:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24395 (presubmit successful).