Issue 17624010: Inline object constructor already in the method recognizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17624010: Inline object constructor already in the method recognizer. (Closed)

Created:
7 years, 6 months ago by Florian Schneider

Modified:
7 years, 6 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline object constructor already in the method recognizer. The call is replaced with "return null". This allows us to always inline calls to "Object." without extra overhead in the generic flow graph inliner. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=24391

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
	M	runtime/vm/intermediate_language.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 6 months ago (2013-06-25 10:56:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24391 (presubmit successful).

Expand Messages | Collapse Messages