Issue 17619013: Bugfix: make the new compilation artifact layout also work with dart2dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17619013: Bugfix: make the new compilation artifact layout also work with dart2dart (Closed)

Created:
7 years, 6 months ago by kustermann

Modified:
7 years, 6 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Bugfix: make the new compilation artifact layout also work with dart2dart TBR=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=24407

Patch Set 2 : #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View	1	1 chunk	+7 lines, -5 lines	1 comment	Download
	M	tools/testing/dart/test_suite.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kustermann

https://codereview.chromium.org/17619013/diff/2001/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/17619013/diff/2001/tools/testing/dart/test_runner.dart#newcode201 tools/testing/dart/test_runner.dart:201: if (fromFile.existsSync()) { Seems like we don't have .map ...

7 years, 6 months ago (2013-06-25 13:58:57 UTC) #1

kustermann

7 years, 6 months ago (2013-06-25 13:59:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r24407 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17619013: Bugfix: make the new compilation artifact layout also work with dart2dart (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages