Issue 17611010: Remove dead code and re-enable short socket read

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17611010: Remove dead code and re-enable short socket read (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove dead code and re-enable short socket read The native function Socket_ReadList have not been used for some time now. Unfortunately the replacement function Socket_Read did not apply short socket reads for testing. This is now in place again. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24394

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -52 lines)			Patch
	M	runtime/bin/io_natives.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	runtime/bin/socket.cc	View		3 chunks	+4 lines, -51 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years, 6 months ago (2013-06-25 11:32:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24394 (presubmit successful).

Expand Messages | Collapse Messages