Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 17608007: Added --exclude-lib=docgen so that it does throw an error about markdown when building. (Closed)

Created:
7 years, 6 months ago by janicejl
Modified:
7 years, 6 months ago
Visibility:
Public.

Description

Added --exclude-lib=docgen so that it does throw an error about markdown when building. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=24421

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -459 lines) Patch
M pkg/docgen/bin/docgen.dart View 1 chunk +47 lines, -381 lines 0 comments Download
A + pkg/docgen/lib/docgen.dart View 19 chunks +209 lines, -77 lines 0 comments Download
M pkg/docgen/pubspec.yaml View 1 chunk +5 lines, -1 line 0 comments Download
M utils/apidoc/apidoc.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
janicejl
https://codereview.chromium.org/17608007/diff/1/pkg/docgen/bin/docgen.dart File pkg/docgen/bin/docgen.dart (right): https://codereview.chromium.org/17608007/diff/1/pkg/docgen/bin/docgen.dart#newcode30 pkg/docgen/bin/docgen.dart:30: parser.addFlag("help", abbr: "h", On 2013/06/24 22:07:11, Andrei Mouravski wrote: ...
7 years, 6 months ago (2013-06-25 00:33:56 UTC) #1
Emily Fortuna
https://codereview.chromium.org/17608007/diff/1/pkg/docgen/bin/docgen.dart File pkg/docgen/bin/docgen.dart (right): https://codereview.chromium.org/17608007/diff/1/pkg/docgen/bin/docgen.dart#newcode30 pkg/docgen/bin/docgen.dart:30: parser.addFlag("help", abbr: "h", On 2013/06/25 00:33:56, janicejl wrote: > ...
7 years, 6 months ago (2013-06-25 00:36:31 UTC) #2
Emily Fortuna
lgtm
7 years, 6 months ago (2013-06-25 02:03:48 UTC) #3
janicejl
7 years, 6 months ago (2013-06-25 16:49:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24421 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698