Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 17601013: Revert "Do not compile tests for different browsers separately" (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Do not compile tests for different browsers separately" We have to use subdirectories instead of special names in the javascript files. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=24408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -74 lines) Patch
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 5 chunks +3 lines, -38 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 11 chunks +17 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
I'll do another CL which uses subdirectories instead.
7 years, 6 months ago (2013-06-25 14:34:08 UTC) #1
ahe
lgtm
7 years, 6 months ago (2013-06-25 14:36:43 UTC) #2
kustermann
7 years, 6 months ago (2013-06-25 14:38:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698