Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 17601008: Report ILLEGAL_CHARACTER for not 'a'-'z' and 'A'-'Z' letters in identifiers. (Closed)

Created:
7 years, 6 months ago by scheglov
Modified:
7 years, 6 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report ILLEGAL_CHARACTER for not 'a'-'z' and 'A'-'Z' letters in identifiers. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24415

Patch Set 1 #

Patch Set 2 : Don't allow invalid letters in the middle of identifiers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/AbstractScanner.java View 1 2 chunks +1 line, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/scanner/AbstractScannerTest.java View 1 1 chunk +9 lines, -1 line 0 comments Download
M tests/co19/co19-analyzer.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 6 months ago (2013-06-25 05:59:43 UTC) #1
Brian Wilkerson
LGTM
7 years, 6 months ago (2013-06-25 14:06:38 UTC) #2
scheglov
7 years, 6 months ago (2013-06-25 16:07:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r24415 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698