Issue 17601006: Implement JsMirrorSystem.libraries.

Issue 17601006: Implement JsMirrorSystem.libraries. (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, kasperl, ngeoffray, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement JsMirrorSystem.libraries. BUG=http://dartbug.com/11484 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=24388

Patch Set 2 : Fix issue with minified mode found during testing. #

Total comments: 2

Patch Set 3 : Add newlines #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -11 lines)			Patch
	M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1	5 chunks	+25 lines, -11 lines	0 comments	Download
	A	dart/tests/lib/mirrors/libraries_test.dart	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

Updated CL to fix an issue with minified mode found during testing.

7 years, 6 months ago (2013-06-25 07:31:51 UTC) #2

ngeoffray

LGTM https://codereview.chromium.org/17601006/diff/3001/dart/tests/lib/mirrors/libraries_test.dart File dart/tests/lib/mirrors/libraries_test.dart (right): https://codereview.chromium.org/17601006/diff/3001/dart/tests/lib/mirrors/libraries_test.dart#newcode13 dart/tests/lib/mirrors/libraries_test.dart:13: Expect.isNotNull(mirrors, 'mirrors is null'); For readability: add a ...

7 years, 6 months ago (2013-06-25 07:37:45 UTC) #3

ahe

Thank you, Nicolas. https://codereview.chromium.org/17601006/diff/3001/dart/tests/lib/mirrors/libraries_test.dart File dart/tests/lib/mirrors/libraries_test.dart (right): https://codereview.chromium.org/17601006/diff/3001/dart/tests/lib/mirrors/libraries_test.dart#newcode13 dart/tests/lib/mirrors/libraries_test.dart:13: Expect.isNotNull(mirrors, 'mirrors is null'); On 2013/06/25 ...

7 years, 6 months ago (2013-06-25 09:25:42 UTC) #4

ahe

7 years, 6 months ago (2013-06-25 09:26:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r24388 (presubmit successful).

Expand Messages | Collapse Messages