Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 17601005: Implement JsClassMirror.constructors. (Closed)

Created:
7 years, 6 months ago by ahe
Modified:
7 years, 6 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, kasperl, ngeoffray, Johnni Winther
Visibility:
Public.

Description

Implement JsClassMirror.constructors. BUG=http://dartbug.com/11486 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=24389

Patch Set 1 #

Patch Set 2 : Rebased on CL 17601006 to fix issues in minified mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -14 lines) Patch
M dart/sdk/lib/_internal/lib/js_mirrors.dart View 1 7 chunks +48 lines, -11 lines 0 comments Download
M dart/sdk/lib/mirrors/mirrors.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/lib/lib.status View 1 1 chunk +0 lines, -1 line 0 comments Download
A dart/tests/lib/mirrors/constructors_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
M dart/tests/lib/mirrors/reflect_model_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
7 years, 6 months ago (2013-06-24 21:49:33 UTC) #1
ahe
Rebased on CL 17601006 to fix issues with minified mode found during testing.
7 years, 6 months ago (2013-06-25 07:34:01 UTC) #2
ngeoffray
LGTM
7 years, 6 months ago (2013-06-25 07:56:27 UTC) #3
ahe
7 years, 6 months ago (2013-06-25 09:33:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698