Issue 1759493002: Get rid of WebSocketChannel.pingInterval.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1759493002: Get rid of WebSocketChannel.pingInterval. (Closed)

Created:
4 years, 9 months ago by nweiz

Modified:
4 years, 9 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/web_socket_channel.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Get rid of WebSocketChannel.pingInterval. This is now set as a constructor parameter for implementations that support it. R=kevmoo@google.com Committed: https://github.com/dart-lang/web_socket_channel/commit/51f8eff2f1cb5fad1592ddd17b227457a4369a0f

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -54 lines)			Patch
M	README.md	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	lib/io.dart	View	3 chunks	+12 lines, -32 lines	0 comments	Download
M	lib/src/channel.dart	View	2 chunks	+10 lines, -17 lines	0 comments	Download

Total messages: 4 (1 generated)

nweiz

4 years, 9 months ago (2016-03-02 00:27:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
51f8eff2f1cb5fad1592ddd17b227457a4369a0f (presubmit successful).