Let operator* in Duration accept doubles.

Let operator* in Duration accept doubles.

BUG= http://dartbug.com/11044
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24411

[floitsch, 2013-06-25 15:28:01]

LGTM with comments.

https://codereview.chromium.org/17591020/diff/14001/sdk/lib/core/duration.dart
File sdk/lib/core/duration.dart (right):

https://codereview.chromium.org/17591020/diff/14001/sdk/lib/core/duration.dar...
sdk/lib/core/duration.dart:59: int microseconds: 0})
Remove trailing space.

https://codereview.chromium.org/17591020/diff/14001/sdk/lib/core/duration.dar...
sdk/lib/core/duration.dart:86: * Note when [factor] is a double, and the
duration is greater than
Note that ...
or:
Note: ...

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
File tests/corelib/duration_big_num_test.dart (right):

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
tests/corelib/duration_big_num_test.dart:11: d1 = new Duration(microseconds:
pow(2,53));
space between , and 53: pow(2, 53)

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
tests/corelib/duration_big_num_test.dart:13: Expect.equals(pow(2,54),
d.inMicroseconds);
ditto.

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
tests/corelib/duration_big_num_test.dart:15: Expect.equals(pow(2,53).toDouble()
* 1.5, d.inMicroseconds);
ditto.

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
tests/corelib/duration_big_num_test.dart:16: }
Add line testing that inMicroseconds still is an integer.
Expect.isTrue(d.inMicroseconds is int);

Also test, that we actually go through the "toDouble":

// Test that we lose precision when multiplying with a double.
d = new Duration(microseconds: pow(2, 53) + 1) * 1.0;
Expect.equals(0, d.inMicroseconds % 2);

[zarah, 2013-06-25 15:54:05]

https://codereview.chromium.org/17591020/diff/14001/sdk/lib/core/duration.dart
File sdk/lib/core/duration.dart (right):

https://codereview.chromium.org/17591020/diff/14001/sdk/lib/core/duration.dar...
sdk/lib/core/duration.dart:59: int microseconds: 0})
On 2013/06/25 15:28:02, floitsch wrote:
> Remove trailing space.

Done.

https://codereview.chromium.org/17591020/diff/14001/sdk/lib/core/duration.dar...
sdk/lib/core/duration.dart:86: * Note when [factor] is a double, and the
duration is greater than
On 2013/06/25 15:28:02, floitsch wrote:
> Note that ...
> or:
> Note: ...

Done.

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
File tests/corelib/duration_big_num_test.dart (right):

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
tests/corelib/duration_big_num_test.dart:11: d1 = new Duration(microseconds:
pow(2,53));
On 2013/06/25 15:28:02, floitsch wrote:
> space between , and 53: pow(2, 53)

Done.

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
tests/corelib/duration_big_num_test.dart:13: Expect.equals(pow(2,54),
d.inMicroseconds);
On 2013/06/25 15:28:02, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
tests/corelib/duration_big_num_test.dart:15: Expect.equals(pow(2,53).toDouble()
* 1.5, d.inMicroseconds);
On 2013/06/25 15:28:02, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/17591020/diff/14001/tests/corelib/duration_bi...
tests/corelib/duration_big_num_test.dart:16: }
On 2013/06/25 15:28:02, floitsch wrote:
> Add line testing that inMicroseconds still is an integer.
> Expect.isTrue(d.inMicroseconds is int);
> 
> Also test, that we actually go through the "toDouble":
> 
> // Test that we lose precision when multiplying with a double.
> d = new Duration(microseconds: pow(2, 53) + 1) * 1.0;
> Expect.equals(0, d.inMicroseconds % 2);

Done.

[zarah, 2013-06-25 15:57:20]

Committed patchset #5 manually as r24411 (presubmit successful).